Skip to content

Update for sokol-gfx resource-view update#84

Merged
floooh merged 4 commits intomainfrom
issue1252/resource_views
Aug 23, 2025
Merged

Update for sokol-gfx resource-view update#84
floooh merged 4 commits intomainfrom
issue1252/resource_views

Conversation

@floooh
Copy link
Copy Markdown
Owner

@floooh floooh commented Aug 12, 2025

See: floooh/sokol#1287

@kassane NOTE: this is in preparation for the upcoming sokol-gfx resource view update which breaks compatibility.

I'll take care of the merge when ready.

As for #83, I added a quick'n'dirty bash script in the meantime. Would be better to add the ability to use a local sokol-shdc to the dub build scripts though.

@floooh
Copy link
Copy Markdown
Owner Author

floooh commented Aug 12, 2025

Ah I forgot to fix the sgl-context sample... one sec.

But some of the errors in CI look like it's building the shaders with the main-branch sokol-shdc.

@kassane
Copy link
Copy Markdown
Collaborator

kassane commented Aug 13, 2025

Tip

Turn off or edit genshaders in CI/CD, avoiding any overwriting of generated shader files during WiP.
https://github.com/kassane/sokol-d/blob/ede49c9d2bc4485aa75a1a7a181e7c1ad478a35a/.github/workflows/build.yml#L36-L37

@kassane kassane added the enhancement New feature or request label Aug 13, 2025
@floooh
Copy link
Copy Markdown
Owner Author

floooh commented Aug 23, 2025

...btw, putting the generation date into the source files wasn't a great idea in hindsight ;)

I'll just merge from main and overwrite the changes, but we might want consider removing the timestamp from the generated source.

Btw, I'll keep the local-compile-shaders.sh helper script in, feel free to remove, but I think it's quite useful.

image

@floooh floooh marked this pull request as ready for review August 23, 2025 14:58
@floooh floooh merged commit 44d6610 into main Aug 23, 2025
14 checks passed
@floooh floooh deleted the issue1252/resource_views branch August 23, 2025 14:58
@kassane
Copy link
Copy Markdown
Collaborator

kassane commented Aug 23, 2025

...btw, putting the generation date into the source files wasn't a great idea in hindsight ;)

I'll just merge from main and overwrite the changes, but we might want consider removing the timestamp from the generated source.

😅 yeah! Agreed, it is undesirable to date the generated files in this case.

@floooh
Copy link
Copy Markdown
Owner Author

floooh commented Aug 23, 2025

FYI @kassane, I found and fixed a bug that slipped in:

If you have versioned packages you might want to push a new minor version once the bindings are updated:

https://github.com/floooh/sokol/actions/runs/17177701249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants