Skip to content

fix: Check if configs appears multiple times when creating an obs #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix: Check if configs appears multiple times when creating an obs #216

merged 1 commit into from
Nov 10, 2023

Conversation

s-kuberski
Copy link
Collaborator

We now check that each idx is sorted in ascending order when creating an Obs and provide more helpful error messages when this is not the case.

Closes #214

@s-kuberski s-kuberski requested a review from fjosw as a code owner November 10, 2023 14:41
@fjosw fjosw merged commit d689959 into fjosw:develop Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjosw fjosw fjosw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate data cause gamma_method() to fail with an unhelpful message
2 participants
@s-kuberski @fjosw