Remove attribute is_merged #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given the speed up, we should probably get rid of this attribute... Therefore, this is fine with me, although I liked to have this extra piece of information in the past. |
|
I agree, that the speed-up outweighs the missing info. I hope that this change does not break any workflows. The only case in which I see problems is trying to unpickle an old pyerrors 2.x pickle file with the new version but I think we made clear that this should be avoided anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
Obsattributeis_mergedwhich is no longer needed after the removal of_filter_zeroes. On my machine, on python 3.8 this results in a ~1.15x speed up for the multiplication of twoObs.