Merged
Conversation
BREAKING CHANGES! - `options.name` and `options.directory` now can contain extension - Ensure the `originalExtension` is an image extension, throw error if not - `options.extension` now must be one of supported image extension by `sharp`, throw error if not - Use `sharp` to actually convert the image format if `options.extension` specified
…directory BREAKING CHANGES!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
urlprovided is an URL to image file (not pdf, docx, or another non-image files).options.extensionis only used to change the file extension on the path, not convert the actual binary file.image.directoryvalue is not an absolute path, unlessoptions.directoryis not set (default)What is the new behavior?
options.nameandoptions.directorynow can contain extensionoriginalExtensionis an image extension, throw error if notoptions.extensionnow must be one of supported image extension bysharp, throw error if notsharpto actually convert the image format ifoptions.extensionspecifiedimage.directorynow always return absolute path of the output directoryOther information
This is BREAKING CHANGES