Skip to content

Revamp#14

Merged
fityannugroho merged 14 commits intomainfrom
revamp
Jun 29, 2024
Merged

Revamp#14
fityannugroho merged 14 commits intomainfrom
revamp

Conversation

@fityannugroho
Copy link
Owner

@fityannugroho fityannugroho commented Jun 26, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Put [x] to check

  • I have read the documentation.
  • I have read and followed the Contributing Guidelines.
  • I have included a pull request description of my changes.
  • I have included the necessary changes to the documentation.
  • I have added tests to cover my changes.

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using [x]

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: N/A

What is the new behavior?

  • feat: add overwrite prevention (cbfb7db, 3c38fd1)
  • feat: add URL validation (ec86105)
  • Upgrade dependencies and changes minimum Node.js version to v20.9 (2075512)
  • feat: imgdl now returns void (2a60f2c)
  • Update all test files, use local mock server msw
  • Update vitest.config.ts, use pool: 'forks' (81ef44c)

Other information

This is BREAKING CHANGES!

Problem that still exists:
Test failed in GitHub Action, but works in local.

@fityannugroho fityannugroho force-pushed the revamp branch 2 times, most recently from a73aa77 to 5dc2128 Compare June 27, 2024 14:21
@fityannugroho fityannugroho force-pushed the revamp branch 2 times, most recently from 7d89f2e to 24b43bb Compare June 28, 2024 15:17
@fityannugroho fityannugroho added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Jun 29, 2024
@fityannugroho fityannugroho marked this pull request as ready for review June 29, 2024 12:28
@fityannugroho fityannugroho merged commit 9be00e8 into main Jun 29, 2024
@fityannugroho fityannugroho deleted the revamp branch March 21, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant