fix: Dockerize improvements - add missing build args and Docker instructions#523
Merged
fityannugroho merged 2 commits intomainfrom Aug 18, 2025
Merged
fix: Dockerize improvements - add missing build args and Docker instructions#523fityannugroho merged 2 commits intomainfrom
fityannugroho merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
The current Docker setup has several issues:
DB_PROVIDERbuild argument indocker-compose.yml, which causes build failures when the Dockerfile expects this argumentWhat is the new behavior?
This PR fixes the Docker configuration and adds comprehensive documentation:
DB_PROVIDERbuild argument to ensure proper Docker builds.github/instructions/docker.instructions.mdwith:The changes ensure that Docker builds work correctly and provide clear guidance for developers on Docker usage patterns.
Other information
Changes made:
DB_PROVIDERbuild arg to fix build failuresThese improvements align with the project's instruction-based development approach and ensure smooth Docker-based development experience.