fix: duplicate Navbar in dev (Turbopack)#73
Merged
fityannugroho merged 1 commit intomainfrom Aug 25, 2025
Merged
Conversation
… (Turbopack) - Added not-found.tsx — group-scoped not-found that does not render Navbar. - Removed not-found.tsx (global not-found) to avoid double rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR scopes the app's Not Found page to the
(main)route group to avoid rendering twoNavbarcomponents during development with Turbopack.What changed
app/(main)/not-found.tsx— a group-scoped Not Found page that does not render theNavbar.app/not-found.tsx— the previous global Not Found which renderedNavbarand caused duplication when a route under(main)returned a not-found.Why
(main)→ page). When a route under(main)returns Not Found, the layout tree still includesapp/(main)/layout.tsx(which rendersNavbar). The globalapp/not-found.tsxalso renderedNavbar, resulting in two navbars being mounted.Verification
next dev --turbobefore the change: navigating to a missing route under(main)showed twoNavbarinstances.Navbarno longer appears for not-found routes under the(main)group.Files changed
app/(main)/not-found.tsx— new group-scoped Not Found pageapp/not-found.tsx— removed global Not Found that includedNavbarNotes & follow-ups
Alternatives considered:
Navbartoapp/layout.tsx(root) if you want the navbar on every route globally.app/not-found.tsxbut ensure it doesn't renderNavbar(same effect).This change is low-risk and only affects the Not Found fallback behavior in dev; production rendering remains consistent.