Conversation
fityannugroho
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move font loading from external CDN to local font assets and refactor font handling to make builds and deployments deterministic.
Changes included
public/fonts(or equivalent) directory.Why
Removing the CDN dependency improves reliability, ensures consistent rendering across environments, and speeds up first meaningful paint for local networks.
How to verify
pnpm devand open the site; check that the app uses the expected local fonts.pnpm buildto ensure there are no build errors related to font imports.Notes
If filenames for fonts changed during the refactor, you may need to invalidate CDN caches for rollout or keep a CDN fallback temporarily.