fix: improve error handling in data fetching functions#58
Merged
fityannugroho merged 1 commit intomainfrom May 16, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
getDataandgetBoundaryDataserver actions will throw 500 error when the servers that defined in.env(DATA_SOURCE_URLandDATA_SOURCE_BOUNDARY_URL) is unreachable/inactive.What is the new behavior?
This pull request improves error handling and network robustness in the
dataanduseBoundarymodules. The changes include adding more descriptive error messages, handling network connection failures, and ensuring consistent error responses.Enhancements to error handling:
hooks/useBoundary.ts: Updated the error message logic to includeres.messageif available, providing more specific error details when an unexpected status code is encountered.lib/data.ts:getData: Added atry-catchblock to handle network connection errors gracefully. If a connection fails, it now returns a structured error response with a500status code and a descriptive message. Additionally, improved error messaging for non-OK responses by including the response body text.getBoundaryData: Similar togetData, added atry-catchblock to handle network errors and return a structured error response with a500status code and a descriptive message. Changed the URL construction to use theURLclass for better readability and maintainability.