Fix Laggy Map Dragging on Mobile with Dark Mode Enabled#42
Merged
fityannugroho merged 3 commits intomainfrom Nov 13, 2024
Merged
Fix Laggy Map Dragging on Mobile with Dark Mode Enabled#42fityannugroho merged 3 commits intomainfrom
fityannugroho merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
Currently, the map experiences lag when dragged on mobile devices with dark mode enabled. The primary cause of this lag is the implementation of dark mode using Tailwind CSS on the map tiles. This setup requires each tile to undergo additional processing to apply the dark theme, resulting in delays that impact performance, especially on mobile.
What is the new behavior?
This pull request includes significant changes to the map component and its dependencies, focusing on improving the map rendering and theming capabilities. The most important changes include the creation of a new
TileLayercomponent, updates to theMapcomponent, and modifications to the package dependencies.Map Component and TileLayer Enhancements:
components/map.tsx: Updated to use the newTileLayercomponent and added amaxZoomproperty to theMapContainer. [1] [2]components/tile-layer.tsx: Created a newTileLayercomponent that integrates with Maplibre GL and dynamically updates the map style based on the current theme.Dependency Updates:
package.json: Added the@maplibre/maplibre-gl-leafletdependency.pnpm-lock.yaml: Updated to include several new dependencies related to Maplibre and other map rendering libraries. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23]Other information
None