Skip to content

fix: added target blank instead of replacing current tab#31

Merged
fityannugroho merged 2 commits intofityannugroho:mainfrom
mazkaaa:dev
Oct 21, 2024
Merged

fix: added target blank instead of replacing current tab#31
fityannugroho merged 2 commits intofityannugroho:mainfrom
mazkaaa:dev

Conversation

@mazkaaa
Copy link
Contributor

@mazkaaa mazkaaa commented Oct 20, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Put [x] to check

  • I have read the documentation.
  • I have read and followed the Contributing Guidelines.
  • I have included a pull request description of my changes.
  • I have included the necessary changes to the documentation.
  • I have added tests to cover my changes.

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using [x]

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • ..... (describe the other type)

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: N/A

Hyperlink on the navbar replacing the URL address on the current tab

What is the new behavior?

I added target _blank to open the link on the new tab instead of replacing the current tab

Other information

none

@vercel
Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
idn-area-map ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 2:19am

Copy link
Owner

@fityannugroho fityannugroho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you run the linter conmand (npm run lint:fix)? The code style said that you should use double-quotes " instead of single quote '

@mazkaaa
Copy link
Contributor Author

mazkaaa commented Oct 21, 2024

Have you run the linter conmand (npm run lint:fix)? The code style said that you should use double-quotes " instead of single quote '

Ahh my bad I forget about it. Pushing the changes right away

@fityannugroho fityannugroho merged commit 69f5cb6 into fityannugroho:main Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants