fix: added target blank instead of replacing current tab#31
Merged
fityannugroho merged 2 commits intofityannugroho:mainfrom Oct 21, 2024
Merged
fix: added target blank instead of replacing current tab#31fityannugroho merged 2 commits intofityannugroho:mainfrom
fityannugroho merged 2 commits intofityannugroho:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fityannugroho
requested changes
Oct 20, 2024
Owner
fityannugroho
left a comment
There was a problem hiding this comment.
Have you run the linter conmand (npm run lint:fix)? The code style said that you should use double-quotes " instead of single quote '
Contributor
Author
Ahh my bad I forget about it. Pushing the changes right away |
fityannugroho
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
Hyperlink on the navbar replacing the URL address on the current tab
What is the new behavior?
I added target _blank to open the link on the new tab instead of replacing the current tab
Other information
none