Fix unhandled validation error, add Not Found Page#28
Merged
fityannugroho merged 6 commits intomainfrom Oct 14, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
Invalid area code will throw unhandled validation error
What is the new behavior?
This pull request includes several changes to improve error handling, simplify the codebase, and enhance the user experience. The most important changes include adding error handling for invalid area codes, simplifying the
Homepage, and creating a newNotFoundpage.Error Handling Improvements:
app/(main)/[code]/page.tsx: Added error handling for invalid area codes ingenerateMetadataandDetailAreaPagefunctions, returning a "Not Found" response when an error occurs.app/api/og-image/area/[code]/route.tsx: Added error handling for invalid area codes, returning a JSON response with a 400 status.Code Simplification:
Homepage by directly returning theMapDashboardcomponent.Homepage implementation that included theNavbarandMapDashboardcomponents.User Experience Enhancements:
NotFoundpage with a user-friendly message and a link to the main page.Metadata Improvements:
Code Cleanup:
lib/utils.ts: Removed theareaCodeSchemaas it is no longer used.Other information
None