Skip to content

Generate OpenGraph image dynamically#17

Merged
fityannugroho merged 4 commits intomainfrom
feat/dynamic-ogimage
Mar 16, 2024
Merged

Generate OpenGraph image dynamically#17
fityannugroho merged 4 commits intomainfrom
feat/dynamic-ogimage

Conversation

@fityannugroho
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

Put [x] to check

  • I have read the documentation.
  • I have read and followed the Contributing Guidelines.
  • I have included a pull request description of my changes.
  • I have included the necessary changes to the documentation.
  • I have added tests to cover my changes.

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using [x]

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: N/A

Previously (see #16), detail pages did not dynamically generate open graphic image (<meta property="og:image"/>). So regardless of the area code provided, og:image will remain the same as og:image for the homepage.

What is the new behavior?

  • Add API endpoint to dynamically generate open graphic image by the area code provided.
  • Refactor the API boundary endpoint, app config, and MapDashboard component.

Other information

None

@fityannugroho fityannugroho added enhancement New feature or request dependencies Pull requests that update a dependency file labels Mar 16, 2024
@vercel
Copy link

vercel bot commented Mar 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
idn-area-map ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 16, 2024 3:54pm

@fityannugroho fityannugroho merged commit 85ca4fa into main Mar 16, 2024
@fityannugroho fityannugroho deleted the feat/dynamic-ogimage branch March 16, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant