Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I was looking at the makefiles inside the firedancer repo to see if it was possible to build agave-ledger-tool as a binary. I checked the src/app/fdctl/Local.mk and I saw that it was possible : agave-ledger-tool: $(OBJDIR)/bin/agave-ledger-tool
And indeed, the make -j fdctl solana agave-ledger-tool worked.
I used it during the testnet restart to create the correct snapshot and the command : agave-ledger-tool --ledger ledger create-snapshot was working too.
Unfortunately, when the testnet restarted, it was not working well and I suspected it come from the version of the agave-ledger-tool that was not correct one to use for snapshot generation.
But it could be useful for validators to directly build this binary easily with make, especially for future restarts.
Maybe there is a reason this is not the case but I would like to submit the idea here (saw a message on discord that developers were more active on github than discord)
Best,
Léo