-
Notifications
You must be signed in to change notification settings - Fork 2.1k
chore: drop support for Skylake instances #5411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7e537c6
to
fea5659
Compare
Testing on CPU Templates pipeline: https://buildkite.com/firecracker/cpu-templates/builds/967/steps/canvas |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5411 +/- ##
==========================================
+ Coverage 83.13% 83.17% +0.04%
==========================================
Files 266 266
Lines 30533 30533
==========================================
+ Hits 25383 25396 +13
+ Misses 5150 5137 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
733414e
to
f0ee009
Compare
f0ee009
to
ec20aa7
Compare
We're dropping official support for our oldest supported instance type. There is no functional change, meaning Firecracker will continue to work on that instance type, but we will drop all automated testing on it. Signed-off-by: Riccardo Mancini <[email protected]>
ec20aa7
to
29c7949
Compare
I fixed the last thing taka mentioned to make the comment clearer
|
Changes
We're dropping official support for our oldest supported instance type. There is no functional change, meaning Firecracker will continue to work on that instance type, but we will drop all automated testing on it.
Reason
Remove unused instance type.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
tools/devtool checkbuild --all
to verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyle
to verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md
.Runbook for Firecracker API changes.
integration tests.
TODO
.rust-vmm
.