Remove signal handling channels correctly #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 27, 2020 15:15
Since the cause is a process-level resource leak, running these benchmarks in a same process (e.g. go test -bench=BenchmarkForwardSignals) doesn't show the difference. Signed-off-by: Kazuyoshi Kato <[email protected]>
The "break" here only break out from the inner select statement. The for loop is keep running and signal.Stop() won't be called. Seems that is the cause of firecracker-microvm#198. Signed-off-by: Kazuyoshi Kato <[email protected]>
xibz
approved these changes
Feb 28, 2020
Contributor
xibz
left a comment
xibz
left a comment
There was a problem hiding this comment.
Can we paste some benchmarks with the old vs fixed changes? Otherwise this looks good
Author
|
Sure. Before the change (c3bc513): After the change (f8cf437): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#198
Description of changes:
The first commit is a benchmark to reproduce the issue. The second commit is actually fixing the issue. We are not removing signal handling channels (sigchan in setupSignals).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.