Skip to content

DomInspector, ToolboxOverlay.attach calls target.client.listTabs twice #6

@groovecoder

Description

@groovecoder

Some of these issues are just me learning how this code works, so feel free to close them without "fixing" ...
toolbox-overlay.js calls listTabs:

  target.client.listTabs(response => {

Then later calls it again inside the arrow function:

    target.client.listTabs(({ tabs, selected }) => {

If I understand correctly, the 2nd call could be:

    target.client.listTabs((response.tabs, response.selected) => {

That would eliminate a duplicate call to listTabs right?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions