Made location object creation from snapshot function public

[jonahbron]

My particular application is watching location changes by location key, and querying for nearby locations. The ability to take the snapshot from the query and directly convert that into a location object for the next query would be very handy. This change makes that possible.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[jonahbron]

I signed it!

[samtstern]

@jwngr thoughts? This does seem useful but I assume you had a reason for making this private in the first place.

[jwngr]

I'm a bit confused as to the exact use case. The intent of the library is to use a GeoQuery's onKeyEntered() method to query for nearby locations. That listener returns the location is a digestible format, as can be seen in the example here.

I guess I am not fully against making this public, but I would like to understand the use case more before we do that.

BTW @jdimond was the one who wrote this code, not me. He may have some opinion on the matter as well.

[jonahbron]

@jwngr Well, my intent was to have a bunch of users, each of which had a location attached to them. The code was querying for users nearby to each other one, based on ID. I wanted to query the location object directly to keep the GeoQuery up-to-date, but that didn't work, apparently because of a thread issue (#40).

So since that doesn't work, I guess my use-case for this has evaporated. If it's not possible to query the locations from the application in parallel with GeoFire, there's no real reason to need to perform that conversion. 😢

[googlebot]

CLAs look good, thanks!

[jonahbron]

Actually, my use-case is still valid. I believe my app isn't working in AppEngine because of a bug (#40), not because of an inherent design flaw in my application. Once that's fixed, my use-case will again be valid.

[samtstern]

@jonahbron looks like some of your AppEngine code got mixed up in this PR, is that intentional?

[jonahbron]

@samtstern Oops, my bad. Let me fix that.

[jonahbron]

@samtstern Fixed. Moved some stuff into the wrong branch.

[melashkov]

@jonahbron would you be able to squash commits?

[jonahbron]

@melashkov I could probably figure out how to do that, but I'm pretty sure you can choose that in Github when you merge.

[vanniktech]

Friendly ping here. @melashkov you can do this now with GitHub (Squash & merge)

[melashkov]

@anniktech I am not a owner of the repo, cant merge 😢

[samtstern]

Thanks for the ping! I will merge this now.

[vanniktech]

Could you also have a look at #76?