Allow actual RegExp objects in the regex field of a textInput #1247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Berlioz
commented
Sep 30, 2022
src/runtime/manifest.ts
Outdated
| @@ -102,6 +102,14 @@ export interface ManifestStack { | |||
| * @internal | |||
| */ | |||
| export function stackToWire(stack: ManifestStack): Record<string, unknown> { | |||
| if (stack.params) { | |||
There was a problem hiding this comment.
In retrospect, I think there's a good argument to be made that this ugly special case should probably live in the generic toSpec() implementation in params/types.ts?
There was a problem hiding this comment.
nice "hack" with super great usability upgrade. Do you want to do that here or on a separate PR.
taeold
approved these changes
Oct 6, 2022
src/runtime/manifest.ts
Outdated
| @@ -102,6 +102,14 @@ export interface ManifestStack { | |||
| * @internal | |||
| */ | |||
| export function stackToWire(stack: ManifestStack): Record<string, unknown> { | |||
| if (stack.params) { | |||
There was a problem hiding this comment.
nice "hack" with super great usability upgrade. Do you want to do that here or on a separate PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not....proud of this hack, but I was writing up some docs for params and frankly I couldn't get the slash escapes right in my head when typing them out, which means it's really not reasonable to expect users to get them right either. Much better to just let them use the same JS regexps that they're used to using, and can copy-paste test.
Is this going to require APi review? The actual wire format hasn't changed.