Skip to content

Refactor the App Check internal call logic used by other products #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 1, 2023

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Change the internal call logic to return the token as just a string, instead of the struct. This prevents the need for the products using the function registry to include the App Check header for the struct definition. Also, use a new future, instead of reusing the public one, which might have lead to confusion with the LastResult functionality.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Local testing of the desktop implementation.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Feb 22, 2023
@a-maurice a-maurice requested a review from AlmostMatt February 22, 2023 01:05
@a-maurice a-maurice merged commit 6bf9316 into main Mar 1, 2023
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

❌  Integration test FAILED

Requested by @a-maurice on commit 6bf9316
Last updated: Tue Feb 28 20:47 PST 2023
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Android] [All 3 os] [1/2 android_device: android_target]
storage [TEST] [ERROR] [Windows] [x64] [openssl]

Add flaky tests to go/fpl-cpp-flake-tracker

@a-maurice a-maurice deleted the am-app_check_internal branch March 1, 2023 01:48
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Mar 1, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 1, 2023
@firebase firebase locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants