Skip to content

Conversation

jescalada
Copy link
Contributor

Fixes #1092.

@jescalada jescalada requested a review from coopernetes July 26, 2025 06:09
@jescalada jescalada self-assigned this Jul 26, 2025
Copy link

netlify bot commented Jul 26, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 450b646
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/688a2b3fe217f100082e66fc

@github-actions github-actions bot added the fix label Jul 26, 2025
Copy link

codecov bot commented Jul 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.29%. Comparing base (464929e) to head (450b646).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1118      +/-   ##
==========================================
+ Coverage   80.25%   80.29%   +0.03%     
==========================================
  Files          59       59              
  Lines        2472     2476       +4     
  Branches      288      289       +1     
==========================================
+ Hits         1984     1988       +4     
  Misses        453      453              
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@coopernetes coopernetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix 🫶

@coopernetes
Copy link
Contributor

@jescalada mind resolving the conflicts here? Would like to get this into 1.19.2 if possible.

@jescalada
Copy link
Contributor Author

@coopernetes Sure! I'll take care of the CI issues too while I'm at it.

@jescalada
Copy link
Contributor Author

@coopernetes Ready to go! 🚀

@coopernetes coopernetes merged commit 333c98a into finos:main Jul 30, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression: parsePush writes to its own module's dir instead of the process root
2 participants