fix: additional user api leaks #1098
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR builds on #1090 by ensuring consistency in how user data is serialised and returned across multiple authentication-related endpoints.
Changes
The following endpoints now return user data using the same public-facing serialisation object introduced in PR #1090:
/auth/login
— returns the user upon successful login/auth/profile
— returns the authenticated user/auth/me
— returns the authenticated userI Introduced a new
loginSuccessHandler
function to encapsulate the login success logic. This allows for easier unit testing of login behavior independently of Passport's internal flow.Note:
/auth/profile
and/auth/me
currently serve the same purpose and return identical responses. Consolidating or removing one of these is a potential cleanup task, but is out of scope for this PR.