feat: mongo connection string & cookie secret from env vars #1086
+45
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow for the setting of configuration for MongoDB database connection string as well as cookie secret via environment variables as an alternative to JSON-based configuration Useful in environments that split config between secrets (ie. stored in a secret manager) and plain app configurations such as commitConfig, attestation, etc. that may not be considered sensitive & wouldn't be appropriate in a secret manager.
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1086 +/- ##
==========================================
+ Coverage 76.87% 76.91% +0.04%
==========================================
Files 55 55
Lines 2266 2270 +4
Branches 252 255 +3
==========================================
+ Hits 1742 1746 +4
Misses 494 494
Partials 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #690
connection string as well as cookie secret via environment
variables as an alternative to JSON-based configuration
Useful in environments that split config between secrets (ie.
stored in a secret manager) and plain app configurations such
as commitConfig, attestation, etc. that may not be considered
sensitive & wouldn't be appropriate in a secret manager.