fix: correct typing for ConfigLoader env #1070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was providing a number which can be coerced to a string but TS is a bit more strict asking for string values for env. Also swapped 0 to false to be more clear and added a docs link.
Add type checking for the server to CI. Type Checking for the whole project would be good but the frontend has some typechecking rules which work fine for the build but tsc doesn't currently respect. Will fix in the future.
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1070 +/- ##
=======================================
Coverage 76.78% 76.78%
=======================================
Files 55 55
Lines 2261 2261
Branches 251 251
=======================================
Hits 1736 1736
Misses 495 495
Partials 30 30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JamieSlome
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: correct typing for ConfigLoader env
Was providing a number which can be coerced to a string but TS is a bit more strict asking for string values for env.
Also swapped 0 to false to be more clear and added a docs link.
chore: add tsc for just server and add to CI
Add type checking for the server to CI.
Type Checking for the whole project would be good but the frontend has some typechecking rules which work fine for the build but tsc doesn't currently respect. Will fix in the future.