Skip to content

Conversation

jescalada
Copy link
Contributor

@jescalada jescalada commented Jun 19, 2025

Fixes #1045.

Note that the Checks Settings expects the v18 CI to complete (required). We should change that to v20 instead:
image

I also deleted an unused test file that was meant for an endpoint that was removed/refactored long ago (as well as duplicate tests for login/logout).

Copy link

netlify bot commented Jun 19, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 770b7d1
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6862927702d41400080ba50d

Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.73%. Comparing base (e7ee0d6) to head (770b7d1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
+ Coverage   75.62%   76.73%   +1.11%     
==========================================
  Files          55       55              
  Lines        2244     2244              
  Branches      251      251              
==========================================
+ Hits         1697     1722      +25     
+ Misses        517      492      -25     
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jescalada jescalada marked this pull request as ready for review June 19, 2025 09:08
Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome enabled auto-merge June 27, 2025 13:30
@JamieSlome
Copy link
Member

@TheJuanAndOnly99 - can you elevate my repository permissions so I can make the necessary adjustments?

@TheJuanAndOnly99
Copy link
Member

@JamieSlome I made you an admin, please let me know when you're finished so I can roll back the admin rights.

@JamieSlome JamieSlome merged commit 41dbc46 into finos:main Jun 30, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing plugin tests - ts-mocha compatibility issue
3 participants