feat(ui): optimize hover interactions and user experience#6
feat(ui): optimize hover interactions and user experience#6lucky20160622 wants to merge 5 commits into
Conversation
…ge base and update agent routing
…skill card layouts - Changed connector routing to redirect to the main connectors page after saving a new connector. - Enhanced layout of agent, connector, knowledge base, and skill cards for better readability and consistency. - Updated button styles and added edit options for owners in various components. - Improved translation handling in agent settings form for create/save actions.
|
Thanks Ray — the card-level UX rework is a real improvement. Moving primary actions (Run / View / Chat / Edit) out of the hover dropdown into persistent CTAs makes the gallery much more discoverable, and the A few things to tighten up before I can merge: 🔴 Blocker: unintended routing regression In - router.replace(`/agents/${saved.id}`)
+ router.replace("/agents")This changes post-create behavior from "land on the new thing you just made" to "bounce back to the list". That's a regression — users lose editing context on the resource they just created, and it contradicts standard SaaS patterns (Notion / Linear / Supabase all keep you on the newly-created entity). It also isn't mentioned in the PR description and seems out of scope for "hover interactions". Please revert both lines. 🔴 Blocker: i18n workflow violation You added an
Please:
Also — the 🟡 Consistency nit: Connector card only shows CTA for owners Other cards (Agent / KB / Workflow) expose a primary CTA to everyone (View / Run / Start Chat) and add Edit for owners. 🟡 Please complete the checklist
Once the two blockers are addressed and build passes, happy to approve and merge. Appreciate the patience — the UX direction is solid. |
|
Thanks for the careful review and for calling out the UX improvements. On the product behavior changes, I’d like to clarify that they were intentional rather than accidental side effects. For the post-create redirect behavior, my reasoning was that these resources in FIM One currently behave more like configurable assets than long-form editors. In that context, returning users to the collection view after first creation can help them continue managing the set, instead of forcing them to stay inside a detail page they may not need immediately. So from my perspective, this is a product choice rather than a routing regression. Similarly, the card CTA changes were designed around discoverability and action clarity across the gallery. Persistent primary actions reduce hidden affordances and make the system easier to scan, especially for first-time users. That said, I understand your preference for aligning with the more common SaaS convention of staying on the newly created entity. If consistency with the existing product pattern is more important here, I’m happy to defer to that direction — but I wanted to explain that these changes were deliberate UX decisions, not accidental scope creep. |
|
Appreciate the thoughtful pushback, Ray — and thanks for landing the i18n cleanup ( On the post-create redirect, I want to engage with your "configurable assets vs long-form editors" framing because it's a fair lens, but I don't think it lands for Agent and Connector specifically in FIM One's current shape: Why Agent/Connector are heavy-configuration, not light assets
Why this belongs in its own PR regardless Even if the list-first redirect turned out to be the better UX — which I don't think it is, but reasonable people can disagree — changing post-create routing is a product decision, not a UI affordance one. It deserves its own issue for discussion, its own PR, and ideally some signal (usage data, user feedback) to weigh against the current convention. Bundling it into a "hover interactions and UX" PR means reviewers and future git-blame readers won't find the reasoning where they expect it. Concretely, for this PR I'd like to:
Still open from the previous round:
Once the two |
|
Short version: once the items below are green, I'll merge. Laying it out as one list so you know exactly what "done" looks like — no more one-at-a-time ping-pong after this round. Must-fix before merge
Quick verify (should be one-line)
Heads-up on post-merge polish Once this lands, I'll likely do a small pass to tighten cross-card consistency in a follow-up commit — things like unifying Appreciate the patience on this one — the UX direction you pushed is real value, just want to land it cleanly. |
Code + design contributions via Gitee (no GitHub account). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
What
Improve user experience by adding and optimizing hover interactions and UI feedback.
Why
Enhance usability, visual responsiveness, and overall user experience for better interaction clarity.
Type
Checklist
uv run ruff check src/ tests/passesuv run pytestpassescd frontend && pnpm buildpasses (if frontend changes)en/andzh/(if UI text changed)