Skip to content

ci: pin dependencies to immutable refs and enable dependabot#230

Open
kgiusti wants to merge 1 commit into
fido-device-onboard:mainfrom
kgiusti:openssf-dependency-pinning
Open

ci: pin dependencies to immutable refs and enable dependabot#230
kgiusti wants to merge 1 commit into
fido-device-onboard:mainfrom
kgiusti:openssf-dependency-pinning

Conversation

@kgiusti

@kgiusti kgiusti commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Pin all GitHub Actions to commit SHAs and Dockerfile base images to digests per OpenSSF Scorecard pinned-dependencies requirements. Standardize action versions across workflows and update all Go module dependencies to latest.

  • pin 14 GitHub Actions by commit SHA across 5 workflow files
  • standardize actions/checkout to v6.0.2 and actions/setup-go to v6.4.0
  • pin golang:1.26-alpine and alpine:3.23 by digest in Dockerfile
  • add .github/dependabot.yml for automated weekly updates
  • add dependency-review workflow for PR vulnerability scanning
  • update all Go module dependencies to latest versions

Closes #226

Assisted-by: Claude:claude-opus-4-6

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Dependabot configuration and updates project dependencies, the Go version, and Docker base images. However, the reviewer identified several critical issues regarding hallucinated or non-existent versions. Specifically, the Go version (1.26), Alpine version (3.23), and several Go module versions (such as cobra v1.10.2 and viper v1.21.0) are invalid and will cause build failures.

Comment thread go.mod
Comment thread Dockerfile
Comment thread Dockerfile
@kgiusti kgiusti linked an issue May 8, 2026 that may be closed by this pull request
@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown

go-test-coverage report

Total test coverage: 71.0% (2221/3126)

Test coverage has changed in the current files, with 89 lines missing coverage.
  file:					uncovered:	current coverage:	base coverage:
  internal/config/manufacturer.go	 51		62.5% (35/56)		64.3% (36/56)
  internal/config/rendezvous.go		 15		53.8% (7/13)		61.5% (8/13)
  internal/state/rvblob.go		 23		76.9% (30/39)		74.4% (29/39)

Comment thread .github/workflows/coverage.yml Outdated
Comment thread .github/workflows/dependency-review.yml Outdated
Comment thread .github/workflows/dependency-review.yml Outdated
Comment thread .github/workflows/dependency-review.yml Outdated
Comment thread .github/workflows/dependency-review.yml Outdated
Comment thread .github/workflows/dependency-review.yml Outdated
Comment thread .github/workflows/analysis.yml
Comment thread .github/workflows/ci.yml
Comment thread .github/dependabot.yml Outdated
Comment thread .github/workflows/dependency-review.yml Outdated
Comment thread .github/workflows/dependency-review.yml Outdated
Comment thread .github/dependabot.yml Outdated
Comment thread .github/dependabot.yml

@knecasov knecasov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added comments.

@kgiusti kgiusti force-pushed the openssf-dependency-pinning branch from 03bf195 to c8e1bfa Compare May 13, 2026 00:22
@kgiusti kgiusti force-pushed the openssf-dependency-pinning branch from c8e1bfa to 47a5029 Compare May 13, 2026 00:32
Pin all GitHub Actions to commit SHAs and Dockerfile base images to
digests per OpenSSF Scorecard pinned-dependencies requirements.
Standardize action versions across workflows and update all Go module
dependencies to latest.

- pin 14 GitHub Actions by commit SHA across 5 workflow files
- standardize actions/checkout to v6.0.2 and actions/setup-go to v6.4.0
- pin golang:1.26-alpine and alpine:3.23 by digest in Dockerfile
- add .github/dependabot.yml for automated weekly updates
- add dependency-review workflow for PR vulnerability scanning
- update all Go module dependencies to latest versions

Closes fido-device-onboard#226

Assisted-by: Claude:claude-opus-4-6
Signed-off-by: Kenneth Giusti <kgiusti@redhat.com>
@kgiusti kgiusti force-pushed the openssf-dependency-pinning branch from 47a5029 to d25b053 Compare May 13, 2026 00:54
@kgiusti kgiusti requested a review from knecasov May 13, 2026 00:55

@knecasov knecasov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments.

@kgiusti kgiusti requested a review from knecasov May 13, 2026 14:05

@knecasov knecasov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much for the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenSSF: use dependency hash pinning ci: align action versions across workflows

2 participants