ci: pin dependencies to immutable refs and enable dependabot#230
Open
kgiusti wants to merge 1 commit into
Open
ci: pin dependencies to immutable refs and enable dependabot#230kgiusti wants to merge 1 commit into
kgiusti wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a Dependabot configuration and updates project dependencies, the Go version, and Docker base images. However, the reviewer identified several critical issues regarding hallucinated or non-existent versions. Specifically, the Go version (1.26), Alpine version (3.23), and several Go module versions (such as cobra v1.10.2 and viper v1.21.0) are invalid and will cause build failures.
|
|
knecasov
reviewed
May 11, 2026
knecasov
reviewed
May 11, 2026
knecasov
reviewed
May 11, 2026
knecasov
reviewed
May 11, 2026
knecasov
reviewed
May 11, 2026
knecasov
reviewed
May 11, 2026
knecasov
reviewed
May 11, 2026
knecasov
reviewed
May 11, 2026
knecasov
reviewed
May 11, 2026
knecasov
reviewed
May 11, 2026
knecasov
reviewed
May 11, 2026
knecasov
reviewed
May 11, 2026
knecasov
reviewed
May 11, 2026
03bf195 to
c8e1bfa
Compare
c8e1bfa to
47a5029
Compare
Pin all GitHub Actions to commit SHAs and Dockerfile base images to digests per OpenSSF Scorecard pinned-dependencies requirements. Standardize action versions across workflows and update all Go module dependencies to latest. - pin 14 GitHub Actions by commit SHA across 5 workflow files - standardize actions/checkout to v6.0.2 and actions/setup-go to v6.4.0 - pin golang:1.26-alpine and alpine:3.23 by digest in Dockerfile - add .github/dependabot.yml for automated weekly updates - add dependency-review workflow for PR vulnerability scanning - update all Go module dependencies to latest versions Closes fido-device-onboard#226 Assisted-by: Claude:claude-opus-4-6 Signed-off-by: Kenneth Giusti <kgiusti@redhat.com>
47a5029 to
d25b053
Compare
knecasov
reviewed
May 13, 2026
knecasov
left a comment
Collaborator
There was a problem hiding this comment.
I added some comments.
knecasov
approved these changes
May 13, 2026
knecasov
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thank you very much for the changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin all GitHub Actions to commit SHAs and Dockerfile base images to digests per OpenSSF Scorecard pinned-dependencies requirements. Standardize action versions across workflows and update all Go module dependencies to latest.
Closes #226
Assisted-by: Claude:claude-opus-4-6