Skip to content

Third party directive example #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 19, 2021

Conversation

OriolAbril
Copy link
Contributor

Related to discussion #44

I figures that would be a good way to show that it already works with matplotlib's
directive for example.

  • Tests written and passed
  • Documentation and changelog entry written, docs build passed
  • All tox checks passed

Copy link
Owner

@felix-hilden felix-hilden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It's nice that the MPL directive works already 😄 I've included some comments below.

@felix-hilden felix-hilden merged commit e83d3b6 into felix-hilden:master Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants