Skip to content

fix(feathers): Paginated<Result> for ServiceMethods.find #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dove
Choose a base branch
from
Open

fix(feathers): Paginated<Result> for ServiceMethods.find #3223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34c88f0
fix(feathers): Paginated<Result> for ServiceMethods.find
fratzinger Jun 22, 2023
73fb821
fix(transport-commons): find with Paginated<T>
fratzinger Jun 22, 2023
eb21865
Merge branch 'dove' into fix/ServiceMethods-find-paginated
fratzinger Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/feathers/src/declarations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export interface ServiceMethods<
ServiceParams = Params,
PatchData = Partial<Data>
> {
find(params?: ServiceParams & { paginate?: PaginationParams }): Promise<Result | Result[]>
find(params?: ServiceParams & { paginate?: PaginationParams }): Promise<Paginated<Result> | Result[]>

get(id: Id, params?: ServiceParams): Promise<Result>

Expand All @@ -95,6 +95,18 @@ export interface ServiceOverloads<
ServiceParams = Params,
PatchData = Partial<Data>
> {
find?(
params?: ServiceParams & {
paginate: false
}
): Promise<Result[]>

find?(
params?: ServiceParams & {
paginate?: PaginationOptions
}
): Promise<Paginated<Result>>

create?(data: Data[], params?: ServiceParams): Promise<Result[]>

update?(id: Id, data: Data, params?: ServiceParams): Promise<Result>
Expand Down
4 changes: 2 additions & 2 deletions packages/transport-commons/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable @typescript-eslint/ban-ts-comment */
import { convert } from '@feathersjs/errors'
import { createDebug } from '@feathersjs/commons'
import { Id, NullableId, Params, ServiceInterface } from '@feathersjs/feathers'
import { Id, NullableId, Paginated, Params, ServiceInterface } from '@feathersjs/feathers'

const debug = createDebug('@feathersjs/transport-commons/client')

Expand Down Expand Up @@ -103,7 +103,7 @@ export class Service<T = any, D = Partial<T>, P extends Params = Params>
}

_find(params: Params = {}) {
return this.send<T | T[]>('find', params.query || {})
return this.send<Paginated<T> | T[]>('find', params.query || {})
}

find(params: Params = {}) {
Expand Down