fix: default custom-env-config settings caused name conflicts #3193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
HOSTNAME is available in most Posix systems by default, so it can override your config/default.json OOTB. This is not a well known fact and a new feature in Dove. This conditions combined cause unexpected bindings, errors and interactions with other parts of your server/app/system.
Suggested solution
Namespace them.
Additional details
This reminds me of another feathers-configuration feature, relating to path resolution, that caused unexpected issues. I chose not to include OAUTH secrets as the origin definition seems imperfect, as it somewhat duplicates the top level origins.
https://github.com/feathersjs/feathers-chat/blob/dove/feathers-chat-ts/config/custom-environment-variables.json