fix: set isMultiStrategy to true when array of strategies is provided #1327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1326
Problem
The
isMultiStrategyproperty inAuthenticationRoutewas always set tofalse, regardless of whether an array of strategies was provided. This caused incorrect callback behavior when all strategies failed - multi-strategy setups received a single status instead of an array of statuses.Solution
AuthenticationRouteconstructor to properly setisMultiStrategy = truewhenArray.isArray(strategyOrStrategies)is trueTesting
test/multi-strategy-callback.test.tsto verify the fix works correctly for both single and multi-strategy scenariosChanges
src/AuthenticationRoute.ts: Fixed line 93 to setisMultiStrategy = truefor array inputstest/multi-strategy-callback.test.ts: Added comprehensive test coverage for the fixVerification
The fix has been tested with the reproduction case from the linked issue and resolves the problem completely.