Run hooks with websockets and rewrite ws headers #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <[email protected]>
mcollina
requested review from
Eomm,
Fdawgs and
climba03003
and removed request for
Fdawgs
Signed-off-by: Matteo Collina <[email protected]>
Signed-off-by: Matteo Collina <[email protected]>
Co-authored-by: Frazer Smith <[email protected]>
|
@Fdawgs ptal |
Signed-off-by: Matteo Collina <[email protected]>
Fdawgs
approved these changes
Mar 22, 2023
Signed-off-by: Matteo Collina <[email protected]>
Signed-off-by: Matteo Collina <[email protected]>
|
Note that this also fixes a regression for the getUpstream() support for Websocket that was changed in fastify/fastify-reply-from#293 |
Eomm
reviewed
Mar 22, 2023
| if (request.headers.cookie) { | ||
| return { ...headers, cookie: request.headers.cookie } | ||
| } | ||
| return { ...headers } |
There was a problem hiding this comment.
Suggested change
| return { ...headers } | |
| return headers |
There was a problem hiding this comment.
This is deliberate to create a new object.
Co-authored-by: Manuel Spigolon <[email protected]>
Co-authored-by: Manuel Spigolon <[email protected]>
|
Yes, this should be a major. |
Co-authored-by: Manuel Spigolon <[email protected]>
Eomm
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct