Skip to content

use fastify-plugin instead of patching directly the metadata #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

eliphazbouye
Copy link
Contributor

Use fastify-plugin instead of patching directly the metadata this pull request is made for fix issue #280

Checklist

@Eomm
Copy link
Member

Eomm commented Feb 27, 2023

Reading the logs https://github.com/fastify/fastify-http-proxy/actions/runs/4283701110/jobs/7459688385

It seems that there is some additional logic on the prefix parameter - it must be debug it out

@eliphazbouye eliphazbouye requested a review from Fdawgs February 27, 2023 17:54
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

@Fdawgs ptal

@Uzlopak Uzlopak linked an issue Feb 27, 2023 that may be closed by this pull request
2 tasks
@Eomm Eomm merged commit 00876ab into fastify:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use fastify-plugin instead of patching directly the metadata
5 participants