quickmath #278
Merged
quickmath #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
Nov 23, 2022
| @@ -12,7 +12,7 @@ function liftErrorCode (code) { | |||
| return 1011 | |||
| } else if (code === 1004 || code === 1005 || code === 1006) { | |||
| // ws module forbid those error codes usage, lift to "application level" (4xxx) | |||
| return 4000 + (code % 1000) | |||
There was a problem hiding this comment.
why was the % 1000) part unnecessary?
There was a problem hiding this comment.
The if clause already narrows the values down to the numbers 1004, 1005 and 1006.
So the % 1000 would just return the numbers 4, 5 and 6.
So we can save us the modulo and directly add 3000 instead of 4000.
kibertoad
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct