Allow attaching multiple WebSocket proxies #258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if multiple WebSockets-enabled proxies are added to the same
fastify.Server
instance at distinct URI prefixes, the program crashes with error:This PR fixes this problem by only attaching one
WebSocket.Server
to the same HTTP server, and then internally dispatches WebSocket connections to different upstreams via longest prefix match lookup among registered prefixes.Checklist
npm run test
npm run benchmark
- it's unavailable in this repositoryand the Code of conduct