Skip to content

Preserve text vs binary frames #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2022
Merged

Preserve text vs binary frames #257

merged 1 commit into from
Jun 29, 2022

Conversation

yoursunny
Copy link
Contributor

fixes #255

One more change needed for GraphQL proxy to work.
I have tested this with graphql-request client.

Checklist

  • run npm run test
  • npm run benchmark - it's unavailable in this repository
  • tests and/or benchmarks are included
  • documentation is changed or added - this is a bug fix for a bug that is not listed in documentation
  • commit message and code follows the Developer's Certification of Origin
    and the Code of conduct

mcollina
mcollina approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 7a376a2 into fastify:master Jun 29, 2022
@mcollina
Copy link
Member

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Websocket proxying changes message format from text to binary
2 participants
@yoursunny @mcollina