Skip to content

Conversation

@ojeytonwilliams
Copy link
Contributor

Checklist

Aside from updating the docs, I think this closes #150

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a unit test for this?

And why not add the option to fastifyCsrfProtection.CookieSerializeOptions?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

this is ok, there is a test for the type

@ojeytonwilliams
Copy link
Contributor Author

And why not add the option to fastifyCsrfProtection.CookieSerializeOptions?

userInfo isn't connected to the cookies, it's just passed to @fastify/csrf when creating a token. I don't think it's correct to combine the types.

Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit a809885 into fastify:main Mar 25, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing userInfo type in options for generateCsrf

4 participants