Skip to content

Parse "nan(n-char-seq-opt)" as required by C++17 20.19.3.7 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Parse "nan(n-char-seq-opt)" as required by C++17 20.19.3.7 #61

merged 1 commit into from
Mar 1, 2021

Conversation

eugenegff
Copy link
Contributor

Parse "nan(n-char-seq-opt)" as required by C++17 20.19.3.7 and C11 7.20.1.3.3.

At least MSVC produces nan(ind) and nan(snan), and according to https://reviews.llvm.org/D70631 MSVC implementation seems to became LLVM std::to_chars().

float => string => float roundtripping was tested for all floats on macOS with custom "charconv" header that includes https://reviews.llvm.org/D70631 patch that added std::to_chars(... float/double ...) capability.

…20.1.3.3. At least MSVC produces nan(ind) and nan(snan), and according to https://reviews.llvm.org/D70631 MSVC implementation seems to became LLVM std::to_chars().
@lemire
Copy link
Member

lemire commented Mar 1, 2021

Happy to merge. It probably can't cause problems. I will produce a new release right away.

@lemire lemire merged commit edd19b3 into fastfloat:main Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants