Skip to content

Don't do warmups for pystats #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

### Bugfixes

#### No warmup runs for pystats

When collecting pystats, pyperformance will no longer perform "warmup runs", to
make sure that the pystats don't have missing information.

#### Removing a git repo on Windows fails

One needs to remove the "read only" flags on certain files in the git repo in order to remove it.
Expand Down
2 changes: 1 addition & 1 deletion bench_runner/benchmark_definitions.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class BenchmarkRepo:

BENCHMARK_REPOS = [
BenchmarkRepo(
"56d12a8fd7cc1432835965d374929bfa7f6f7a07",
"29cd683acc3eddfd878aa87ef52c15aa4a53641e",
"https://github.com/python/pyperformance.git",
"pyperformance",
),
Expand Down
2 changes: 1 addition & 1 deletion bench_runner/scripts/run_benchmarks.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def collect_pystats(
if LOOPS_FILE_ENV_VAR not in os.environ:
os.environ[LOOPS_FILE_ENV_VAR] = "loops.json"

extra_args = ["--hook", "pystats"]
extra_args = ["--hook", "pystats", "--warmups", "0"]

if flags is None:
flags = []
Expand Down
4 changes: 0 additions & 4 deletions tests/test_run_benchmarks.py
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,3 @@ def test_run_benchmarks_flags(benchmarks_checkout):
f"python-main-{platform.python_version()}-9d38120.json"
) as fd:
json.load(fd)


def test_get_benchmark_hash():
assert benchmark_definitions.get_benchmark_hash() == "dcfded"