ci: use `make` through `cmake` #2746

ekoops · 2025-12-11T09:58:28Z

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

/kind sync

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR avoids using directly make by replacing its invocations with cmake ones wherever possible. Contextually, it tries to use the maximum level of parallelism possible with --parallel $(nproc).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/milestone 0.23.0

Does this PR introduce a user-facing change?:

NONE

github-actions · 2025-12-11T10:09:03Z

Perf diff from master - unit tests

     5.12%    +12.74%  [.] std::__shared_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2>::__shared_ptr(std::__weak_ptr<sinsp_threadinfo, (__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
     4.10%    +10.26%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::_M_get_use_count() const
     4.79%     +9.87%  [.] sinsp_threadinfo::get_main_thread()
     4.02%     +7.74%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_add_ref_lock_nothrow()
     3.83%     +7.14%  [.] sinsp_threadinfo::update_main_fdtable()
     3.60%     +6.81%  [.] sinsp_threadinfo::get_fd_table()
     6.87%     +6.14%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release()
     2.39%     +6.05%  [.] std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count(std::__weak_count<(__gnu_cxx::_Lock_policy)2> const&, std::nothrow_t)
    13.10%     -5.36%  [.] sinsp::next(sinsp_evt**)
     2.10%     +4.08%  [.] thread_group_info::get_first_thread() const

Heap diff from master - unit tests

peak heap memory consumption: 27.68K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0883         -0.0885           248           226           247           226
BM_sinsp_split_median                                          -0.0879         -0.0880           248           226           247           226
BM_sinsp_split_stddev                                          -0.4759         -0.4834             1             1             1             1
BM_sinsp_split_cv                                              -0.4251         -0.4332             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0339         +0.0339            70            72            70            72
BM_sinsp_concatenate_paths_relative_path_median                +0.0355         +0.0354            70            72            69            72
BM_sinsp_concatenate_paths_relative_path_stddev                -0.1625         -0.1617             1             1             1             1
BM_sinsp_concatenate_paths_relative_path_cv                    -0.1900         -0.1892             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0883         -0.0885            44            40            44            40
BM_sinsp_concatenate_paths_empty_path_median                   -0.0811         -0.0814            44            40            44            40
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.5429         -0.5445             1             0             1             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.4987         -0.5003             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0295         +0.0296            71            73            71            73
BM_sinsp_concatenate_paths_absolute_path_median                +0.0291         +0.0292            71            73            71            73
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.4039         -0.4043             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.4210         -0.4214             0             0             0             0

codecov · 2025-12-11T10:14:19Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.56%. Comparing base (5baecd8) to head (4f97098).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2746   +/-   ##
=======================================
  Coverage   74.56%   74.56%           
=======================================
  Files         292      292           
  Lines       29998    29998           
  Branches     4651     4651           
=======================================
  Hits        22367    22367           
  Misses       7631     7631

Flag	Coverage Δ
libsinsp	`74.56% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

irozzo-1A

/lgtm nice clean-up!

ekoops · 2025-12-11T11:58:31Z

kernel-tests-dev CI failures are not related to these changes.

ekoops · 2025-12-11T12:01:39Z

/hold

Avoid using directly `make` by replacing its invocations with `cmake` ones. Contextually, use the maximum level of parallelism with `--parallel $(nproc)`. Signed-off-by: Leonardo Di Giovanna <[email protected]>

Avoid using directly `make` by replacing its invocations with `cmake` ones. Signed-off-by: Leonardo Di Giovanna <[email protected]>

Avoid using directly `make` by replacing its invocations with `cmake` ones. Contextually, build `unit-test-libsinsp`, `bench` and `sinsp-example` together in the same `cmake` invocation and use the maximum level of parallelism with `--parallel $(nproc)`. Signed-off-by: Leonardo Di Giovanna <[email protected]>

Avoid using directly `make` by replacing its invocations with `cmake` ones. Contextually, use the maximum level of parallelism with `--parallel $(nproc)`. Signed-off-by: Leonardo Di Giovanna <[email protected]>

Avoid using directly `make` by replacing its invocations with `cmake` ones. Signed-off-by: Leonardo Di Giovanna <[email protected]>

Avoid using directly `make` by replacing its invocations with `cmake` ones. Contextually, use the maximum level of parallelism with `--parallel $(nproc)`. Signed-off-by: Leonardo Di Giovanna <[email protected]>

Signed-off-by: Leonardo Di Giovanna <[email protected]>

ekoops · 2025-12-11T12:55:57Z

/remove-hold

irozzo-1A

/lgtm

poiana · 2025-12-11T13:10:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, irozzo-1A

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ekoops]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

github-project-automation bot added this to Falco Roadmap Dec 11, 2025

github-project-automation bot moved this to Todo in Falco Roadmap Dec 11, 2025

poiana added this to the 0.23.0 milestone Dec 11, 2025

poiana added kind/cleanup release-note-none dco-signoff: yes area/CI size/L labels Dec 11, 2025

poiana requested review from irozzo-1A and terror96 December 11, 2025 09:58

poiana added the approved label Dec 11, 2025

ekoops force-pushed the ekoops/use-cmake branch from 9806668 to 51c6497 Compare December 11, 2025 10:05

ekoops force-pushed the ekoops/use-cmake branch 5 times, most recently from a0a81ee to 426411d Compare December 11, 2025 11:32

irozzo-1A previously approved these changes Dec 11, 2025

View reviewed changes

poiana assigned irozzo-1A Dec 11, 2025

poiana added the lgtm label Dec 11, 2025

poiana added the do-not-merge/hold label Dec 11, 2025

ekoops dismissed irozzo-1A’s stale review via c1e7f2d December 11, 2025 12:34

ekoops force-pushed the ekoops/use-cmake branch from 426411d to c1e7f2d Compare December 11, 2025 12:34

ekoops added 3 commits December 11, 2025 13:38

ci(ci): use make through cmake

4cadcd4

Avoid using directly `make` by replacing its invocations with `cmake` ones. Contextually, use the maximum level of parallelism with `--parallel $(nproc)`. Signed-off-by: Leonardo Di Giovanna <[email protected]>

ci(e2e_ci): use make through cmake

8377279

Avoid using directly `make` by replacing its invocations with `cmake` ones. Signed-off-by: Leonardo Di Giovanna <[email protected]>

ekoops added 4 commits December 11, 2025 13:38

ci(reusable_e2e_tests): use make through cmake

ee2db6d

Avoid using directly `make` by replacing its invocations with `cmake` ones. Contextually, use the maximum level of parallelism with `--parallel $(nproc)`. Signed-off-by: Leonardo Di Giovanna <[email protected]>

ci(install-deps.sh): use make through cmake

5ecfae0

Avoid using directly `make` by replacing its invocations with `cmake` ones. Signed-off-by: Leonardo Di Giovanna <[email protected]>

ci(test_coverage_ci): use make through cmake

6960f8f

Avoid using directly `make` by replacing its invocations with `cmake` ones. Contextually, use the maximum level of parallelism with `--parallel $(nproc)`. Signed-off-by: Leonardo Di Giovanna <[email protected]>

ci(drivers_ci): use make through cmake

3853c26

Avoid using directly `make` by replacing its invocations with `cmake` ones. Contextually, use the maximum level of parallelism with `--parallel $(nproc)`. Signed-off-by: Leonardo Di Giovanna <[email protected]>

ekoops force-pushed the ekoops/use-cmake branch 2 times, most recently from 0bca40b to 3853c26 Compare December 11, 2025 12:54

chore(driver): remove forgotten comment

4f97098

Signed-off-by: Leonardo Di Giovanna <[email protected]>

ekoops force-pushed the ekoops/use-cmake branch from fe5f704 to 4f97098 Compare December 11, 2025 12:55

poiana removed the do-not-merge/hold label Dec 11, 2025

ekoops requested a review from irozzo-1A December 11, 2025 12:58

irozzo-1A approved these changes Dec 11, 2025

View reviewed changes

leogr approved these changes Dec 11, 2025

View reviewed changes

github-project-automation bot moved this from Todo to In progress in Falco Roadmap Dec 11, 2025

poiana assigned leogr Dec 11, 2025

poiana merged commit 35f5e23 into master Dec 11, 2025
53 of 55 checks passed

poiana deleted the ekoops/use-cmake branch December 11, 2025 13:14

github-project-automation bot moved this from In progress to Done in Falco Roadmap Dec 11, 2025

BrewTestBot mentioned this pull request Dec 23, 2025

falcosecurity-libs 0.23.0 Homebrew/homebrew-core#259846

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci: use `make` through `cmake` #2746

ci: use `make` through `cmake` #2746

Uh oh!

ekoops commented Dec 11, 2025

Uh oh!

github-actions bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

codecov bot commented Dec 11, 2025 •

edited

Loading

Uh oh!

irozzo-1A left a comment

Uh oh!

ekoops commented Dec 11, 2025

Uh oh!

ekoops commented Dec 11, 2025

Uh oh!

ekoops commented Dec 11, 2025

Uh oh!

irozzo-1A left a comment

Uh oh!

poiana commented Dec 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ci: use make through cmake #2746

ci: use make through cmake #2746

Uh oh!

Conversation

ekoops commented Dec 11, 2025

Uh oh!

github-actions bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf diff from master - unit tests

Heap diff from master - unit tests

Heap diff from master - scap file

Benchmarks diff from master

Uh oh!

codecov bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

irozzo-1A left a comment

Choose a reason for hiding this comment

Uh oh!

ekoops commented Dec 11, 2025

Uh oh!

ekoops commented Dec 11, 2025

Uh oh!

ekoops commented Dec 11, 2025

Uh oh!

irozzo-1A left a comment

Choose a reason for hiding this comment

Uh oh!

poiana commented Dec 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ci: use `make` through `cmake` #2746

ci: use `make` through `cmake` #2746

github-actions bot commented Dec 11, 2025 •

edited

Loading

codecov bot commented Dec 11, 2025 •

edited

Loading