-
Notifications
You must be signed in to change notification settings - Fork 176
ci(perf.yml): use python venv to run gbench result comparison #2738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2738 +/- ##
=======================================
Coverage 77.02% 77.02%
=======================================
Files 296 296
Lines 30818 30818
Branches 4670 4670
=======================================
Hits 23738 23738
Misses 7080 7080
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b679615 to
fd5e84c
Compare
235b3ef to
12c3741
Compare
Perf diff from master - unit testsHeap diff from master - unit testsHeap diff from master - scap fileBenchmarks diff from master |
Signed-off-by: Leonardo Di Giovanna <[email protected]>
Signed-off-by: Leonardo Di Giovanna <[email protected]>
12c3741 to
0a11138
Compare
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area CI
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR fixes the issue in https://github.com/falcosecurity/libs/actions/runs/19959292467/job/57236907247 by running gbench result comparison in a separate python virtual environment, and bumping the gbench version to a version newer than 1.9.4 (not released yet, but this is the only way to avoid dependency issues with python 3.12).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/milestone 0.23.0
Does this PR introduce a user-facing change?: