feat!: stabilize EF_TMP_CONVERTER_MANAGED as EF_CONVERTER_MANAGED
#2659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neither `EF_OLD_VERSION` can be used to always imply `EF_TMP_CONVERTER_MANAGED`, nor `EF_TMP_CONVERTER_MANAGED` can be used to always imply `EF_OLD_VERSION`. Indeed: - some enter events are just old event that must be dropped and they are not marked as `EF_TMP_CONVERTER_MANAGED` (e.g.: `PPME_SYSCALL_VFORK_E`) - some enter events must be converted to their new versions leveraging the scap converter, but are not old versions of anything, so they are not marked as `EF_OLD_VERSION` (e.g.: `PPME_SYSCALL_OPEN_E`). For this reason, stabilize `EF_TMP_CONVERTER_MANAGED` as `EF_CONVERTER_MANAGED`. BREAKING CHANGE: change `EF_TMP_CONVERTER_MANAGED` flag name Signed-off-by: Leonardo Di Giovanna <[email protected]>
poiana
added
kind/cleanup
kind/design
kind/documentation
|
Please double check driver/SCHEMA_VERSION file. See versioning. /hold |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2659 +/- ##
=======================================
Coverage 78.18% 78.18%
=======================================
Files 292 292
Lines 31781 31781
Branches 4656 4656
=======================================
Hits 24848 24848
Misses 6933 6933
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leogr
approved these changes
Sep 30, 2025
89 tasks
X64 kernel testing matrix
ARM64 kernel testing matrix
|
Member
👇
👇 /remove-hold |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepskyblue86, ekoops The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind design
/kind documentation
/kind test
/kind feature
Any specific area of the project related to this PR?
/area libscap-engine-savefile
/area libsinsp
/area tests
/area proposals
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Neither
EF_OLD_VERSIONcan be used to always implyEF_TMP_CONVERTER_MANAGED, norEF_TMP_CONVERTER_MANAGEDcan be used to always implyEF_OLD_VERSION.Indeed:
EF_TMP_CONVERTER_MANAGED(e.g.:PPME_SYSCALL_VFORK_E)EF_OLD_VERSION(e.g.:PPME_SYSCALL_OPEN_E).For this reason, this PR stabilizes
EF_TMP_CONVERTER_MANAGEDasEF_CONVERTER_MANAGED.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Not bumping the driver schema version is currently a practice we are following as we will bump it in a single shot once we are done with the #2068 proposal.
/milestone 0.22.0
Does this PR introduce a user-facing change?: