feat!: make PPME_SYSCALL_EXECVE{AT,_19}_E "scap converter"-managed

[ekoops]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR makes PPME_SYSCALL_EXECVE{AT,_19}_E "scap converter"-managed. Moreover, it removes from sinsp any reference to old accept{,4} events. As a bonus, it switches some comments type from TODO to note, as they are consideration, not points that need to be addressed.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Not bumping the driver schema version is currently a practice we are following as we will bump it in a single shot once we are done with the #2068 proposal.

/milestone 0.22.0

Does this PR introduce a user-facing change?:

feat!: make PPME_SYSCALL_EXECVE{AT,_19}_E "scap converter"-managed

[github-actions]

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

[codecov]

Codecov Report

❌ Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.20%. Comparing base (f45917b) to head (71c44e5).
⚠️ Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
userspace/libsinsp/sinsp_filtercheck_event.cpp	0.00%	4 Missing ⚠️
userspace/libsinsp/event.cpp	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2650      +/-   ##
==========================================
+ Coverage   78.19%   78.20%   +0.01%     
==========================================
  Files         292      292              
  Lines       31789    31779      -10     
  Branches     4655     4652       -3     
==========================================
- Hits        24857    24853       -4     
+ Misses       6932     6926       -6     

Flag	Coverage Δ
libsinsp	78.20% <22.22%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[irozzo-1A]

/lgtm

[leogr]

/approve
/remove-hold

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, irozzo-1A, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ekoops,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment