refactor: fix some compiler warnings

[ekoops]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR just fixes some compilation warnings.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/milestone 0.22.0

Does this PR introduce a user-facing change?:

NONE

[github-actions]

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

[ekoops]

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

False positive.
/hold cancel

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.16%. Comparing base (a32d88b) to head (b318d7d).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2633      +/-   ##
==========================================
- Coverage   78.25%   78.16%   -0.10%     
==========================================
  Files         294      294              
  Lines       31826    31864      +38     
  Branches     4667     4680      +13     
==========================================
  Hits        24905    24905              
- Misses       6921     6959      +38     

Flag	Coverage Δ
libsinsp	78.16% <100.00%> (-0.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Perf diff from master - unit tests

     6.02%     +0.74%  [.] sinsp_evt::get_type
     1.55%     -0.29%  [.] libsinsp::sinsp_suppress::process_event
     5.75%     -0.29%  [.] sinsp_thread_manager::find_thread
     3.11%     +0.27%  [.] gzfile_read
     5.52%     -0.25%  [.] sinsp_parser::reset
     8.20%     -0.22%  [.] sinsp::next
     1.73%     -0.18%  [.] can_query_os_for_thread_info
     0.28%     +0.17%  [.] sinsp_evt::is_filtered_out
     0.82%     -0.17%  [.] sinsp_evt::get_direction
     3.02%     -0.17%  [.] is_conversion_needed

Heap diff from master - unit tests

peak heap memory consumption: 8.63K
peak RSS (including heaptrack overhead): 0B
total memory leaked: -895.61K

Heap diff from master - scap file

peak heap memory consumption: 8.63K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0387         -0.0387           152           146           152           146
BM_sinsp_split_median                                          -0.0382         -0.0383           151           145           151           145
BM_sinsp_split_stddev                                          -0.5108         -0.5111             3             2             3             2
BM_sinsp_split_cv                                              -0.4911         -0.4914             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.1462         +0.1462            54            61            54            61
BM_sinsp_concatenate_paths_relative_path_median                +0.1697         +0.1697            52            61            52            61
BM_sinsp_concatenate_paths_relative_path_stddev                -0.8577         -0.8578             2             0             2             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.8759         -0.8760             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0354         -0.0354            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0346         -0.0346            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.4419         -0.4417             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.4214         -0.4212             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0509         +0.0509            60            63            60            63
BM_sinsp_concatenate_paths_absolute_path_median                +0.0363         +0.0363            60            63            60            63
BM_sinsp_concatenate_paths_absolute_path_stddev                +2.1824         +2.1820             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +2.0282         +2.0279             0             0             0             0

[leogr]

/approve

[irozzo-1A]

/lgtm

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, irozzo-1A, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ekoops,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment