Skip to content

Conversation

@ekoops
Copy link
Contributor

@ekoops ekoops commented Sep 8, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR is part of #2588.

Specifically, this addresses the following system calls:

  • preadv
  • pwritev
  • readv
  • writev
  • pread
  • pwrite
  • socket
  • bind
  • listen

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Not bumping the driver schema version is currently a practice we are following as we will bump it in a single shot once we are done with the #2068 proposal.

/milestone 0.22.0

Does this PR introduce a user-facing change?:

feat!: drop `listen` enter evts gen, testing and parsing code
feat!: drop `bind` enter evts gen, testing and parsing code
feat!: drop `socket` enter evts gen, testing and parsing code
feat!: drop `pwrite` enter evts gen, testing and parsing code
feat!: drop `pread` enter evts gen, testing and parsing code
feat!: drop `writev` enter evts gen, testing and parsing code
feat!: drop `readv` enter evts gen, testing and parsing code
feat!: drop `pwritev` enter evts gen, testing and parsing code
feat!: drop `preadv` enter evts gen, testing and parsing code

As the `preadv` exit events contain all the information needed, drop
`preadv` enter events generation from all drivers, and all related
testing and parsing code.

BREAKING CHANGE: drop `preadv` enter evts gen and parsing

Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `pwritev` exit events contain all the information needed, drop
`pwritev` enter events generation from all drivers, and all related
testing and parsing code.

BREAKING CHANGE: drop `pwritev` enter evts gen and parsing

Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `readv` exit events contain all the information needed, drop
`readv` enter events generation from all drivers, and all related
testing and parsing code.

BREAKING CHANGE: drop `readv` enter evts gen and parsing

Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `writev` exit events contain all the information needed, drop
`writev` enter events generation from all drivers, and all related
testing and parsing code.

BREAKING CHANGE: drop `writev` enter evts gen and parsing

Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `pread` exit events contain all the information needed, drop
`pread` enter events generation from all drivers, and all related
testing and parsing code.

BREAKING CHANGE: drop `pread` enter evts gen and parsing

Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `pwrite` exit events contain all the information needed, drop
`pwrite` enter events generation from all drivers, and all related
testing and parsing code.

BREAKING CHANGE: drop `pwrite` enter evts gen and parsing

Signed-off-by: Leonardo Di Giovanna <[email protected]>
@poiana poiana added this to the 0.22.0 milestone Sep 8, 2025
@ekoops ekoops changed the title Ekoops/drop syscall e feat!: drop some syscalls enter events gen, testing and parsing code (part 15) Sep 8, 2025
@poiana poiana added the size/XXL label Sep 8, 2025
@poiana poiana added the approved label Sep 8, 2025
@github-actions
Copy link

github-actions bot commented Sep 8, 2025

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

@github-actions
Copy link

github-actions bot commented Sep 8, 2025

Perf diff from master - unit tests

     1.41%     +0.28%  [.] scap_event_decode_params
     6.02%     +0.23%  [.] sinsp_evt::get_type
     5.75%     -0.23%  [.] sinsp_thread_manager::find_thread
     2.69%     -0.22%  [.] sinsp_thread_manager::get_thread_ref
     0.28%     +0.21%  [.] sinsp_evt::is_filtered_out
     1.13%     -0.21%  [.] libsinsp::events::is_unknown_event
     1.73%     +0.20%  [.] can_query_os_for_thread_info
     1.65%     -0.20%  [.] user_group_updater::~user_group_updater
     1.47%     +0.19%  [.] std::vector<sinsp_evt_param, std::allocator<sinsp_evt_param> >::emplace_back<sinsp_evt*, unsigned int&, char const*, unsigned long&>
     1.16%     +0.18%  [.] sinsp_evt_filter::sinsp_evt_filter

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: -884.97K

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0017         -0.0017           152           151           152           151
BM_sinsp_split_median                                          -0.0017         -0.0017           151           151           151           151
BM_sinsp_split_stddev                                          -0.3711         -0.3714             3             2             3             2
BM_sinsp_split_cv                                              -0.3701         -0.3704             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.1617         +0.1617            54            62            54            62
BM_sinsp_concatenate_paths_relative_path_median                +0.1886         +0.1886            52            62            52            62
BM_sinsp_concatenate_paths_relative_path_stddev                -0.6465         -0.6465             2             1             2             1
BM_sinsp_concatenate_paths_relative_path_cv                    -0.6957         -0.6957             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0005         +0.0005            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   -0.0068         -0.0068            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   +3.8126         +3.8184             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +3.8102         +3.8160             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0078         -0.0078            60            60            60            60
BM_sinsp_concatenate_paths_absolute_path_median                -0.0220         -0.0220            60            59            60            59
BM_sinsp_concatenate_paths_absolute_path_stddev                +2.0661         +2.0650             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +2.0901         +2.0890             0             0             0             0

@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.09%. Comparing base (8fbe6fb) to head (c20c801).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2614   +/-   ##
=======================================
  Coverage   78.09%   78.09%           
=======================================
  Files         298      298           
  Lines       31979    31976    -3     
  Branches     4696     4696           
=======================================
- Hits        24974    24972    -2     
+ Misses       7005     7004    -1     
Flag Coverage Δ
libsinsp 78.09% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Sep 8, 2025

X64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-4.19 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2-5.10 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2023-6.1 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.0 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.7 🟢 🟢 🟢 🟢 🟢 🟢
centos-3.10 🟢 🟢 🟢 🟡 🟡 🟡
centos-4.18 🟢 🟢 🟢 🟢 🟢 🟢
centos-5.14 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.17 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.8 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-3.10 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-4.14 🟢 🟢 🟢 🟢 🟢 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-5.4 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-4.15 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-5.8 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

ARM64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

As the `socket` exit events contain all the information needed, drop
`socket` enter events generation from all drivers, and all related
testing and parsing code.

BREAKING CHANGE: drop `socket` enter evts gen and parsing

Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `bind` exit events contain all the information needed, drop
`bind` enter events generation from all drivers, and all related
testing and parsing code.

BREAKING CHANGE: drop `bind` enter evts gen and parsing

Signed-off-by: Leonardo Di Giovanna <[email protected]>
gnosek
gnosek previously approved these changes Sep 8, 2025
As the `listen` exit events contain all the information needed, drop
`listen` enter events generation from all drivers, and all related
testing and parsing code.

BREAKING CHANGE: drop `listen` enter evts gen and parsing

Signed-off-by: Leonardo Di Giovanna <[email protected]>
Copy link
Member

@deepskyblue86 deepskyblue86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepskyblue86, ekoops

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [deepskyblue86,ekoops]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Sep 8, 2025
@ekoops
Copy link
Contributor Author

ekoops commented Sep 8, 2025

/hold cancel

@poiana poiana merged commit 7c40230 into master Sep 8, 2025
65 of 70 checks passed
@poiana poiana deleted the ekoops/drop-syscall-e branch September 8, 2025 14:32
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Sep 8, 2025
@leogr leogr modified the milestones: 0.22.0, 9.0.0+driver Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants