-
Notifications
You must be signed in to change notification settings - Fork 176
feat!: drop some syscalls enter events gen, testing and parsing code (part 13) #2611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As the `open_by_handle_at` exit events contain all the information needed, drop `open_by_handle_at` enter events generation from all drivers, and all related testing and parsing code. BREAKING CHANGE: drop `open_by_handle_at` enter evts gen and parsing Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `pipe2` exit events contain all the information needed, drop `pipe2` enter events generation from all drivers, and all related testing and parsing code. BREAKING CHANGE: drop `pipe2` enter evts gen and parsing Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `process_vm_{read,write}v` exit events contain all the
information needed, drop `process_vm_{read,write}v` enter events
generation from all drivers, and all related testing and parsing code.
BREAKING CHANGE: drop `process_vm_{read,write}v` entr evts gen/parsing
Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `shutdown` exit events contain all the information needed, drop `shutdown` enter events generation from all drivers, and all related testing and parsing code. BREAKING CHANGE: drop `shutdown` enter evts gen and parsing Signed-off-by: Leonardo Di Giovanna <[email protected]>
|
Please double check driver/SCHEMA_VERSION file. See versioning. /hold |
Perf diff from master - unit testsHeap diff from master - unit testsHeap diff from master - scap fileBenchmarks diff from master |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2611 +/- ##
=======================================
Coverage 78.09% 78.09%
=======================================
Files 298 298
Lines 31987 31979 -8
Branches 4696 4696
=======================================
- Hits 24980 24974 -6
+ Misses 7007 7005 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
X64 kernel testing matrix
ARM64 kernel testing matrix
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, irozzo-1A The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
What type of PR is this?
/kind cleanup
/kind test
/kind feature
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area libscap-engine-gvisor
/area libpman
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR is part of #2588.
Specifically, this addresses the following system calls:
open_by_handle_atpipe2process_vm_readvprocess_vm_writevshutdownWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Not bumping the driver schema version is currently a practice we are following as we will bump it in a single shot once we are done with the #2068 proposal.
/milestone 0.22.0
Does this PR introduce a user-facing change?: