-
Notifications
You must be signed in to change notification settings - Fork 176
feat!: drop some syscalls enter events gen, testing and parsing code (part 8) #2606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As the `{,t,tg}kill` exit events contain all the information needed,
drop `{,t,tg}kill` enter events generation from all drivers, and all
related testing and parsing code.
BREAKING CHANGE: drop `{,t,tg}kill` enter evts gen and parsing
Signed-off-by: Leonardo Di Giovanna <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Please double check driver/SCHEMA_VERSION file. See versioning. /hold |
6913b44 to
793616a
Compare
As the `dup{,2,3}` exit events contain all the information needed,
drop `dup{,2,3}` enter events generation from all drivers, and all
related testing and parsing code.
BREAKING CHANGE: drop `dup{,2,3}` enter evts gen and parsing
Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `inotify_init{,1}` exit events contain all the information
needed, drop `inotify_init{,1}` enter events generation from all
drivers, and all related testing and parsing code.
BREAKING CHANGE: drop `inotify_init{,1}` enter evts gen and parsing
Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `nanosleep` exit events contain all the information needed, drop `nanosleep` enter events generation from all drivers, and all related testing and parsing code. BREAKING CHANGE: drop `nanosleep` enter evts gen and parsing Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `timerfd_create` exit events contain all the information needed, drop `timerfd_create` enter events generation from all drivers, and all related testing and parsing code. BREAKING CHANGE: drop `timerfd_create` enter evts gen and parsing Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `setgid` exit events contain all the information needed, drop `setgid` enter events generation from all drivers, and all related testing and parsing code. BREAKING CHANGE: drop `setgid` enter evts gen and parsing Signed-off-by: Leonardo Di Giovanna <[email protected]>
As the `access` exit events contain all the information needed, drop `access` enter events generation from all drivers, and all related testing and parsing code. BREAKING CHANGE: drop `access` enter evts gen and parsing Signed-off-by: Leonardo Di Giovanna <[email protected]>
793616a to
0fd207a
Compare
X64 kernel testing matrix
ARM64 kernel testing matrix
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2606 +/- ##
=======================================
Coverage 78.10% 78.10%
=======================================
Files 298 298
Lines 32050 32030 -20
Branches 4696 4696
=======================================
- Hits 25033 25018 -15
+ Misses 7017 7012 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/hold cancel |
What type of PR is this?
/kind cleanup
/kind test
/kind feature
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area libscap-engine-gvisor
/area libpman
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR is part of #2588.
Specifically, this addresses the following system calls:
killtkilltgkilldupdup2dup3inotify_initinotify_init1nanosleeptimerfd_createsetgidaccessWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Not bumping the driver schema version is currently a practice we are following as we will bump it in a single shot once we are done with the #2068 proposal.
/milestone 0.22.0
Does this PR introduce a user-facing change?: