feat!: drop some syscalls enter events gen, testing and parsing code (part 4) #2594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
release-note
dco-signoff: yes
kind/cleanup
kind/test
|
Please double check driver/SCHEMA_VERSION file. See versioning. /hold |
Contributor
|
/milestone 0.22.0 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2594 +/- ##
==========================================
- Coverage 78.16% 78.15% -0.01%
==========================================
Files 298 298
Lines 32079 32069 -10
Branches 4691 4691
==========================================
- Hits 25075 25065 -10
Misses 7004 7004
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
/unhold |
Contributor
|
Triggered kernel testing matrix: https://github.com/falcosecurity/libs/actions/runs/17380325436 |
Contributor
X64 kernel testing matrix
ARM64 kernel testing matrix
|
Contributor
|
Zig build CI error is not related to this PR, and the issue was mitigated here: #2597 |
Contributor
|
LGTM label has been added. DetailsGit tree hash: da50c9ae91e3f90f9469f197b66d819eada952bd |
leogr
previously approved these changes
Sep 1, 2025
Contributor
|
/override "CI Build / build-libs-linux-amd64 😁 (zig) (pull_request)" |
1 similar comment
Member
|
/override "CI Build / build-libs-linux-amd64 😁 (zig) (pull_request)" |
terror96
force-pushed
the
drop-syscall-enter-events-1
branch
from
216b713 to
fe622bf
Compare
ekoops
changed the title
ekoops
reviewed
Sep 2, 2025
terror96
force-pushed
the
drop-syscall-enter-events-1
branch
from
fe622bf to
eab1fe4
Compare
As the `setuid` exit events contain all the information needed, drop `setuid` enter events generation from all drivers, and all related testing and parsing code. BREAKING CHANGE: drop `setuid` enter events generation and parsing Signed-off-by: Tero Kauppinen <[email protected]>
As the `ptrace` exit events contain all the information needed, drop `ptrace` enter events generation from all drivers, and all related testing and parsing code. BREAKING CHANGE: drop `ptrace` enter events generation and parsing Signed-off-by: Tero Kauppinen <[email protected]>
…sing code As the `mkdir_2` and `mkdirat` exit events contain all the information needed, drop `mkdir_2` and `mkdirat` enter events generation from all drivers, and all related testing and parsing code. BREAKING CHANGE: drop `mkdir_2` and `mkdirat` enter events generation and parsing Signed-off-by: Tero Kauppinen <[email protected]>
As the `fchdir` exit events contain all the information needed, drop `fchdir` enter events generation from all drivers, and all related testing and parsing code. BREAKING CHANGE: drop `fchdir` enter events generation and parsing Signed-off-by: Tero Kauppinen <[email protected]>
terror96
force-pushed
the
drop-syscall-enter-events-1
branch
from
eab1fe4 to
90728fe
Compare
Contributor
|
LGTM label has been added. DetailsGit tree hash: 2f49ccbe73c395b4172af1090ce12532d7999bcd |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, terror96 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
leogr
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind test
/kind feature
Any specific area of the project related to this PR?
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area libpman
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR is part of #2588.
Specifically, this addresses the following system calls:
setuidptracemkdirmkdiratfchdirWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Not bumping the driver schema version is currently a practice we are following as we will bump it in a single shot once we are done with the #2068 proposal.
Does this PR introduce a user-facing change?: