fix(userspace/libsinsp): remove state handling for PPM_SYSCALL_RMDIR #2549
Conversation
The current implementation does no longer emit PPME_SYSCALL_MKDIR_X events and these events are also converted to PPME_SYSCALL_MKDIR_2_X events for older scap files. Remove unused PPME_SYSCALL_MKDIR_X statements from the codebase. Added the CIF_FALLBACK_TO_EMPTY flag for parameters copied from the enter event. Signed-off-by: Tero Kauppinen <[email protected]>
The new driver does not emit `PPM_SYSCALL_RMDIR` events anymore, and there is no longer need to handle the old version of the rmdir event. This update removes the state handling and adds conversion rules for the scap files. Signed-off-by: Tero Kauppinen <[email protected]>
|
/milestone 0.22 |
|
@ekoops: The provided milestone is not valid for this repository. Milestones in this repository: [ Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2549 +/- ##
==========================================
- Coverage 78.03% 78.02% -0.01%
==========================================
Files 292 292
Lines 32153 32142 -11
Branches 4704 4704
==========================================
- Hits 25089 25078 -11
Misses 7064 7064
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/milestone 0.22.0 |
|
LGTM label has been added. DetailsGit tree hash: 3c41f8c81849d3c2244d2b2f8fa295a3006da5e7 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, FedeDP, terror96 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
The new driver does not emit
PPM_SYSCALL_RMDIRevents anymore, and there is no longer need to handle the old version of the rmdir event. This update removes the state handling and adds conversion rules for the scap files.This update also cleans up unused PPME_SYSCALL_MKDIR_X statements.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libscap-engine-savefile
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
/version driver-API-version-minor
/version driver-SCHEMA-version-minor
What this PR does / why we need it:
This update adds missing conversion rules for old scap events to the new events and eliminates the need to store the entry event information.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The version number was pumped as for #2480.
Does this PR introduce a user-facing change?: