cleanup(libsinsp): retrieve parameters from the prlimit exit events #2545
Conversation
|
Please double check driver/SCHEMA_VERSION file. See versioning. /hold |
There is no need to store the prlimit entry event, because all required parameters are available in the exit event. Modify the prlimit exit event handler to retrieve information from the exit event instead of the entry event. Added scap conversion rules for the exit event with 5 parameters. Signed-off-by: Tero Kauppinen <[email protected]>
terror96
force-pushed
the
cleanup-prlimit-event-handling
branch
from
17a7acf to
6110087
Compare
|
/milestone 0.22.0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2545 +/- ##
=======================================
Coverage 78.05% 78.05%
=======================================
Files 292 292
Lines 32157 32167 +10
Branches 4692 4693 +1
=======================================
+ Hits 25099 25109 +10
Misses 7058 7058
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM label has been added. DetailsGit tree hash: cda8c385e938f6ac5e63c7164b747ea950a4bfbb |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, terror96 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Not bumping the driver schema version is currently a practice we are following as we will bump it in a single shot once we are done with the #2427 initiative. So we can safely ignore the failing driver-schema check. |
|
/hold cancel |
4 participants
There is no need to store the prlimit entry event, because all required parameters are available in the exit event.
Modify the prlimit exit event handler to retrieve information from the exit event instead of the entry event. Added scap conversion rules for the exit event with 5 parameters.
What type of PR is this?
Any specific area of the project related to this PR?
/area libscap
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR removes the need to process enter events for the prlimit syscall by utilizing the corresponding parameters available in the exit event.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: